BUGFIX: Partial publish breaks uri and change Projection #5293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP DO NOT MERGE, it's just a test showing the behavior. |
|
The latest commit fixes the issue at least for new events, but we still need a solution for existing events. |
|
The fix is more of a proof-of-concept. I will work on virtual workspaces now and adjust the fix to that once it's done. |
|
Fyi this was my virtual workspace name draft: #5167 |
|
also this can then be fixed with catchup hooks |
A partial publish results in events annotated for "live" workspace yet are not in the "live" content stream. This is due to a fork of the live content stream being created with the partially published events in, which is then published to the actual live content stream. This leaves behind duplicate events both containing "workspaceName: live" yet only one of them is in the live content stream. A catchup or replay will fail however due to duplicate database entries for the reflections relying on anything with "workspaceName: live" being actually in the live content stream. The provided test fails showing the behavior.
kitsunet
force-pushed
the
task/partial-publish-bug
branch
from
ef2d459 to
3dd9069
Compare
|
I have no clue why these Behat tests are failing, they are fine on my machine and I can't see the relation between the test and what I changed in this. |
|
i cherry picked the test to our big pr and also documented why we are not going that way in #5327 so that why we can close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A partial publish results in events annotated for "live" workspace yet are not in the "live" content stream.
This is due to a fork of the live content stream being created with the partially published events in, which is then published to the actual live content stream.
This leaves behind duplicate events both containing "workspaceName: live" yet only one of them is in the live content stream. A catchup or replay will fail however due to duplicate database entries for the projections relying on anything with "workspaceName: live" being actually in the live content stream.
The provided test fails showing the behavior.
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions